Commit graph

105 commits

Author SHA1 Message Date
Minchan Kim
09e63f9519 Revert "powerhint: add proactive kill hint for camera launch"
Revert submission 27473137-P24_PA_KILL_HINT_24Q4

Reason for revert: will merge after mid of June

Reverted changes: /q/submissionid:27473137-P24_PA_KILL_HINT_24Q4

Change-Id: Ie6fadb9881a00486ff631ab286aca9ff062a7a40
Bug: 322916612
2024-05-30 00:58:50 +00:00
Richard Chang
15705aa358 powerhint: add proactive kill hint for camera launch
Bug: 322916612
Test: local test
Change-Id: I9f65cbbb7bcb4a85afee50d1a85a753deebd1386
2024-05-23 03:46:22 +00:00
Taeju Park
c3ffd4e875 powerhint: bug fix for PMU_FORCE_LIMIT am: 8a52ed0919
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27441386

Change-Id: Ib2a7edbec896398ea7816989e76672a56651cd17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-21 21:44:57 +00:00
Taeju Park
8a52ed0919 powerhint: bug fix for PMU_FORCE_LIMIT
PMU_FORCE_LIMIT node is used without declaration

Bug: 341151887
Change-Id: I6ca864d80e25a5c81f04606d0a3315edd1357386
Signed-off-by: Taeju Park <taeju@google.com>
2024-05-21 18:50:49 +00:00
Ali K. Zadeh
df45ec3772 60fps: change PMU max frequency for CL2 to 1164MHz am: c14ec8230a
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27327800

Change-Id: I700e17de5b99ee53ad2b9335268d22aad13adc81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-17 05:35:16 +00:00
Ali K. Zadeh
c14ec8230a 60fps: change PMU max frequency for CL2 to 1164MHz
Bug: 340289125
Test: clock residency
(https://docs.google.com/spreadsheets/d/1TQQU5TGHE6B0xOgd77tyUyGnU-oksXi1X0Bs_vCsENE/edit#gid=1243247080)
Test: Kibble (https://docs.google.com/spreadsheets/d/1WF9WVVeNvDSawzUtrq-L89jh1vuAootVET3vRXQTJR8/edit#gid=1987296588)

Change-Id: I18fc6a3ffe535278d95ea32e855d3b8b8ab12b4a
2024-05-16 22:18:54 +00:00
Taeju Park
70bbca81db Merge "powerhint: add PMU_FORCE_LIMIT control knob" into 24D1-dev am: ef1f5d317a
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27215478

Change-Id: I6b5eeefd3448f5f5072053a8eae3ea6ca1c413b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-10 19:21:08 +00:00
Taeju Park
ef1f5d317a Merge "powerhint: add PMU_FORCE_LIMIT control knob" into 24D1-dev 2024-05-10 19:07:40 +00:00
Ali K. Zadeh
38b4b1562b Merge "Enable PMU during photo capture" into 24D1-dev am: 0508270ad8
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27238472

Change-Id: Icb25839791a8bed17ee44af3de72f8bd2485e890
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-10 00:17:48 +00:00
Ali K. Zadeh
0508270ad8 Merge "Enable PMU during photo capture" into 24D1-dev 2024-05-09 23:58:52 +00:00
Ali K. Zadeh
730f445f01 Enable PMU during photo capture
Bug: 298227152
Test: Kibble 12MP - https://docs.google.com/spreadsheets/d/1Exxzy_7CHu4RQQ_-eR2s16Ob9BpxdQZFn6GIkUmoc4k/edit?resourcekey=0-CrG5HCXn9v7iR0PFk84j2g#gid=328258859
Test: Kibble 50MP - https://docs.google.com/spreadsheets/d/1qIdxci3qRwgM_XD5rRdmQPqDrsf8VHQIqQggDh2rgGY/edit?resourcekey=0-t25YyqKalsLbrCM7ADDHlQ#gid=2134912777
Test: Kibble 12MP - repeated capture - https://docs.google.com/spreadsheets/d/1XTwC5iCaobxwCcj5QH1f_34lJysvFDv53wt4K9l8DAM/edit#gid=1477598242
Test: Kibble 50MP - repeated capture - https://docs.google.com/spreadsheets/d/17wlxE2MsRx56Vhr9IE1iBYLz1Lee1s7Bb7E_GKaBJtc/edit?resourcekey=0-Vh8vf55xZHgYnWqDESm5lA#gid=1630323952
Test: Latency 12MP - https://docs.google.com/spreadsheets/d/1xUmS4H8SmwKzrL-CScIhZABsrlCq1CZsDT9ZSWFAMwU/edit#gid=466916271
Test: Latency 50MP - https://docs.google.com/spreadsheets/d/1GUs1TVCCOD6Bv73ilxrjg99tJVq6wQ5kJfYrJ1djY54/edit#gid=1885938822
Change-Id: I5083184f9e226d42584de5b6910994f1d5d3cc52
2024-05-09 22:44:32 +00:00
Rick Yiu
8f96f84997 Set big core to group_cfs_skip_mask for sys group am: d8c84c47ff
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27280353

Change-Id: Ia3e88bd2b40c562e24e46adaab15baca7613025d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-09 16:45:19 +00:00
Rick Yiu
d8c84c47ff Set big core to group_cfs_skip_mask for sys group
Set big core to group_cfs_skip_mask for sys group when screen is off,
so that sys group tasks will run less in big core.

Bug: 328210236
Test: suspend/resume test
Change-Id: I4868ba0303e981250105b1ff69a6db6458df844a
2024-05-09 16:06:24 +00:00
Rick Yiu
f0d17434a3 Merge "Revert^2 "Set big core to cpu skip mask by default"" into 24D1-dev am: 1ae838086c
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27232593

Change-Id: Ifcb474ab364936e79a89b661a8f9f6dd1ce3ce57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-08 10:01:30 +00:00
Rick Yiu
1ae838086c Merge "Revert^2 "Set big core to cpu skip mask by default"" into 24D1-dev 2024-05-08 09:33:23 +00:00
Rick Yiu
4958f15db0 Revert^2 "Set big core to cpu skip mask by default"
This reverts commit b64afc1747.

Reason for revert: regression fixed

Bug: 248621289
Change-Id: Ia3479262bf7188b2abf35f5b5ec5f18b0fe63aff
Test: build pass
2024-05-07 07:39:47 +00:00
Taeju Park
3cfc93b4f6 powerhint: add PMU_FORCE_LIMIT control knob
Bug: 335331630
Change-Id: Idb5f21cdb98611edd07d3edcafca5699515e9bae
Signed-off-by: Taeju Park <taeju@google.com>
2024-05-06 19:33:24 +00:00
Wei Wang
075542984b Merge "Revert "Set big core to cpu skip mask by default"" into 24D1-dev am: c381116bd3
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27197299

Change-Id: I1ec937a6d44a9bea5df6c7735dc78eaf322515e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-02 21:41:58 +00:00
Wei Wang
c381116bd3 Merge "Revert "Set big core to cpu skip mask by default"" into 24D1-dev 2024-05-02 21:28:03 +00:00
Wei Wang
b64afc1747 Revert "Set big core to cpu skip mask by default"
This reverts commit 2cc7bc7c3d.

Reason for revert: may get geekbench5/6 regressed
Bug: 338140604
Bug: 338141118
Change-Id: I76b2b98ca233fccc1f9a15c99bbb622bd7869392
2024-05-02 20:26:43 +00:00
Ali K. Zadeh
285947989b Merge "Change PMU_BIG_LIMIT_FREQUENCY of 1298MHz to 1396MHz" into 24D1-dev am: 7563d4d627
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27032752

Change-Id: I469fa82043f4a54f11426d99ac677710fb3467b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-02 01:11:29 +00:00
Ali K. Zadeh
7563d4d627 Merge "Change PMU_BIG_LIMIT_FREQUENCY of 1298MHz to 1396MHz" into 24D1-dev 2024-05-02 00:49:03 +00:00
Treehugger Robot
6f3b88fabd Merge "Add POWER_EFFICIENCY uclamp max to adpf config" into 24D1-dev am: dba4c9beb1
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27160429

Change-Id: I0de65b01398996e3623037c19a54382bbc5753d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-30 19:25:26 +00:00
Matt Buckley
4a19787592 Add POWER_EFFICIENCY uclamp max to adpf config
Add the "UclampMax_EfficientBase" value to the ADPF config in the
powerhint.json to specify efficient core scheduling in the static
case, and "UclampMax_EfficientOffset" for the dynamic case, for this
device.

Bug: 277285195
Test: manual
Change-Id: If377f6384a1a7863abf80f0a4a0cf0fe3074ec21
2024-04-30 16:54:35 +00:00
Ali K. Zadeh
c67b4aa7eb Merge "Disable CDPreferIdle, set DSUMin to 610MHz for 60fps" into 24D1-dev am: 32364863c3
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27091363

Change-Id: Iab05035312bfe3c13afb5b0c3f8495af9932f2b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-29 20:44:19 +00:00
Ali K. Zadeh
32364863c3 Merge "Disable CDPreferIdle, set DSUMin to 610MHz for 60fps" into 24D1-dev 2024-04-29 20:22:15 +00:00
Ali K. Zadeh
c4c7bb09b2 Merge "Reduce DVFSHeadroom to 1100 for CAMERA_STREAMING_STANDARD" into 24D1-dev am: a4151229c8
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27120048

Change-Id: I64b267ca92676ff44e3eb44f7a6fb9f36b1aa67c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-26 22:21:03 +00:00
Ali K. Zadeh
a4151229c8 Merge "Reduce DVFSHeadroom to 1100 for CAMERA_STREAMING_STANDARD" into 24D1-dev 2024-04-26 22:03:46 +00:00
Taeju Park
cbc71795e2 powerhint: tune default value for PMU limit parameter am: 635801795b
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27120732

Change-Id: Ia2f92c7c44e81d2f18e543ba2ece868a5e07698f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-26 21:27:42 +00:00
Taeju Park
635801795b powerhint: tune default value for PMU limit parameter
Bug: 310237445
Change-Id: I0ed334a447afdc420655ca1733125e8ab0ab43f1
Signed-off-by: Taeju Park <taeju@google.com>
2024-04-26 18:32:42 +00:00
Wei Wang
7e62ae947e Merge "powerhint: remove lcpi parameter for PMU limit" into 24D1-dev am: 95295f6e14
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27004355

Change-Id: Id56747874c0f6840e57813b880bedfdd47cb33a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-26 18:08:08 +00:00
Wei Wang
95295f6e14 Merge "powerhint: remove lcpi parameter for PMU limit" into 24D1-dev 2024-04-26 17:49:54 +00:00
Ali K. Zadeh
f81ce08592 Reduce DVFSHeadroom to 1100 for CAMERA_STREAMING_STANDARD
With CDPreferIdle enabled, the current DVFSHeadroom pushes the CL0
frequency too high. This CL reduces this value to 1100, resulting in a
lower CPU power while performance remains mostly intact.

Bug: 304536786
Test: 1080p30fps - https://docs.google.com/spreadsheets/d/1A6Ck6Hyhs5su_xhn_6YIrLKSGc-tVIbzMIcGP4ucp-w/edit?resourcekey=0-Tj0KiAgzcejZJAUem9D2Ew#gid=2127971741
Test: 4k30fps - https://docs.google.com/spreadsheets/d/1scT3e3jeAekH6L7vZ3WtLLJsRxyxaq6JxbXKW4_tkH8/edit#gid=1060301792
Test: Photo preview - https://docs.google.com/spreadsheets/d/1W8WhkDqZccYvh4Zd0wXNFaCxWrUY-TOuXoFuBSVkk88/edit?resourcekey=0-i8drOxv0D8QioXYJNhZyGA#gid=380332953
Test: Portrait preview - https://docs.google.com/spreadsheets/d/1g9olzsTKNodKH8o0EtlcYbmLHOSbwnUVLyHAGs89tTE/edit?resourcekey=0-az_TeGJi_aH-B_DGqyTugQ#gid=524055346
Test: Video Bokeh - https://docs.google.com/spreadsheets/d/162XjO8vhbL9JFolzjqDUhaMp40NWWQP7PMr_34JS8PE/edit?resourcekey=0-gtA-l_Z0c_aDK5Y898XnrA#gid=1290026232
Test: 120fps - https://docs.google.com/spreadsheets/d/1nSA2ybed-fu6RqBdsa0JZ4CRM6002HPYiW3dJC_rxvw/edit#gid=961019110
Test: loaded test - https://docs.google.com/spreadsheets/d/1wGlPn_WdX5ZJAhppmZBh_Iih3UcSwGQeDb8R-OG2Jhk/edit?resourcekey=0-NKPtSKHqq1HwPwZDw7OljA#gid=1710307951
Change-Id: I1271c60e669dbf437467f28903254bb95a07beb0
2024-04-26 17:13:32 +00:00
Treehugger Robot
8ab79fd705 Merge "Set big core to cpu skip mask by default" into 24D1-dev am: 5c92151009
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/26875089

Change-Id: Ic8e31a313e8a1b93718113fc1ca3d169712dd227
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-26 04:32:14 +00:00
Treehugger Robot
5c92151009 Merge "Set big core to cpu skip mask by default" into 24D1-dev 2024-04-26 04:14:05 +00:00
Treehugger Robot
05cbb24496 Merge "Adpf:caimito: revert heuristic boost triggering condition." into 24D1-dev am: 4c7c69f0e3
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27103268

Change-Id: I92ba1771466ddbd92c6ddc47cb82646ebbdfa2ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-26 03:02:16 +00:00
Treehugger Robot
4c7c69f0e3 Merge "Adpf:caimito: revert heuristic boost triggering condition." into 24D1-dev 2024-04-26 02:42:19 +00:00
Yadong Xu
baf9f99098 Merge "Fix face auth powerhint for face unlock boost" into 24D1-dev am: 5b49713231
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27006675

Change-Id: I23d123533be2c545f542e87c4f7e3fc2b2fa82c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-26 00:38:05 +00:00
Yadong Xu
5b49713231 Merge "Fix face auth powerhint for face unlock boost" into 24D1-dev 2024-04-26 00:18:11 +00:00
Yadong Xu
71395ffb99 Fix face auth powerhint for face unlock boost
Test: Not required.

Fixed:335714087

Change-Id: I2f19bd4df763a6665762d67c3df66d444805e5a4
2024-04-26 00:17:54 +00:00
guibing
2ea470d49a Adpf:caimito: revert heuristic boost triggering condition.
This reverts previous JankCheckTimeFactor from 1.43 to 1.2.

Since the current reported duration doesn't include the GPU
part, the JankCheckTimeFactor needs to be smaller for matching
jank frame detection.

Bug: 204204746
Test: adb shell dumpsys android.hardware.power.Ipower/default;
      check adpf sessions' traces.
Change-Id: I36ab5e699187650011a91a2c0814c33e62e4e125
2024-04-25 22:52:05 +00:00
Ali K. Zadeh
9c39373a33 Disable CDPreferIdle, set DSUMin to 610MHz for 60fps
With MulticamRoutingNode on RT, the performance is no longer impacted by
having CDPreferIdle disabled. Additionally, this CL reduces DSUMin to
610MHz, saving overall up to 50mW in CPU power.

Test: 1080p60: https://docs.google.com/spreadsheets/d/1KoMO-hFl8t5KxLOWTn9eGSEXJqMVhDh4PRgn94_aTfk/edit?usp=sharing&resourcekey=0-DnXRxfkqmKNE8Cbh664inA
Test: 4k60: https://docs.google.com/spreadsheets/d/1PntdXFCyBL4H3kswAoIRota-FGbqSHXRZCQP3opnuj8/edit?usp=sharing&resourcekey=0--wdtPAqsz2XbsHQq67rgeg
Bug: 334945465
Bug: 304536786
Change-Id: Ic1d24975c01c65f8495a26ad9b29c97efed85ee1
2024-04-24 22:38:19 +00:00
Taeju Park
04a98d59e4 powerhint: remove lcpi parameter for PMU limit
PMU-based soft freq limit no longer use lcpi parameter

Bug: 295054083
Change-Id: I0d4eb0d90934dcd441e7272292c34cffa533ae25
Signed-off-by: Taeju Park <taeju@google.com>
2024-04-23 20:29:56 +00:00
Rick Yiu
2cc7bc7c3d Set big core to cpu skip mask by default
Also reset the mask for launch and other camera streaming modes that
do not use it.

Bug: 248621289
Test: build pass
Change-Id: I752bcf27ac6c9064a464af54200a506fd6db03ff
2024-04-23 05:29:35 +00:00
Ali K. Zadeh
47817d91c4 Merge "Increase SPC thresholds for 60fps" into 24D1-dev am: 3d27c634c1
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27032799

Change-Id: I21ac474351c2c142e0644d4498cae23ef59d7a8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-22 21:31:41 +00:00
Ali K. Zadeh
5ef91438ed Merge "Make PreferHighcap settings for VideoCall consistent between devices" into 24D1-dev am: aa9721834c
Original change: https://googleplex-android-review.googlesource.com/c/device/google/caimito/+/27030005

Change-Id: Id7e317d070c34a1f281b5ee013e15d5d54768c96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-22 21:31:14 +00:00
Ali K. Zadeh
3f30ceb9e1 Change PMU_BIG_LIMIT_FREQUENCY of 1298MHz to 1396MHz
1298MHz is no longer in the list of available frequencies of the big
core. This CL replaces this value with the next available one which is
1396MHz.

Bug: 304536786
Test: device boot
Change-Id: I2f58c18c41494e0a0ea4b006f641f55405b72cfd
2024-04-22 21:11:25 +00:00
Ali K. Zadeh
3d27c634c1 Merge "Increase SPC thresholds for 60fps" into 24D1-dev 2024-04-22 21:11:03 +00:00
Ali K. Zadeh
c3a6514d48 Increase SPC thresholds for 60fps
This CL increase SPC threshold for little core to 55, and for mid core
to 32. Tests show that in a loaded scenario, framedrop rate can reduce
to almost zero, while not impacting the power in the unloaded (baseline)
scenario.

Bug: 304536786
Test: 1080p60: https://docs.google.com/spreadsheets/d/10g6mWm8q9FgnBDvC1CzYWgVM6DZZJQLdAYqf2zW209U/edit?usp=sharing
Test: 4k60: https://docs.google.com/spreadsheets/d/1Rnz5gkqgoHFz5vwq5uezy8JD1uGkq_52fqDAmBetafY/edit?usp=sharing&resourcekey=0-zAOJ1GPbHWGYdU5QlUaH3Q
Test: Loaded - 1080p60: https://docs.google.com/spreadsheets/d/1Ae1sFdXfHL0R_za3o7tUhws-4Xs3F7XktPld9Eh0xYE/edit?usp=sharing&resourcekey=0-dPQmBCXISNX_GA8s2uzLcw
Test: Loaded - 4k60: https://docs.google.com/spreadsheets/d/1QeSJjTRhyL41Bjm9wF9tKcC8mHpC02vkr6R2qJlNA1w/edit?usp=sharing
Change-Id: I077a42349527721f31eeb10c4521f48c1448374a
2024-04-19 22:02:04 +00:00
Ali K. Zadeh
c2a2ce209d Make PreferHighcap settings for VideoCall consistent between devices
Bug: 323257509
Test: device boot
Change-Id: I3ba16e14c75847ef0bf08dee946ead65d762f63c
2024-04-19 18:10:58 +00:00