Amir Goldstein b5b2dbf1a2 UPSTREAM: locks: fix TOCTOU race when granting write lease ...

Thread A trying to acquire a write lease checks the value of i_readcount
and i_writecount in check_conflicting_open() to verify that its own fd
is the only fd referencing the file.

Thread B trying to open the file for read will call break_lease() in
do_dentry_open() before incrementing i_readcount, which leaves a small
window where thread A can acquire the write lease and then thread B
completes the open of the file for read without breaking the write lease
that was acquired by thread A.

Fix this race by incrementing i_readcount before checking for existing
leases, same as the case with i_writecount.

Use a helper put_file_access() to decrement i_readcount or i_writecount
in do_dentry_open() and __fput().

BUG:263029637
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Qi Han <hanqi@vivo.com>
Change-Id: I18efc0bbc0197ca24153ffb9079552ecaebe36b5
(cherry picked from commit d6da19c9cace63290ccfccb1fc35151ffefc0bec)

2022-12-20 17:38:16 +00:00

35 KiB

Raw Blame History

View Raw